Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

level.dat from 1.8 is ingored when loading in 1.8.9 [Fix] #2477

Closed
Jay113355 opened this issue Feb 17, 2016 · 2 comments
Closed

level.dat from 1.8 is ingored when loading in 1.8.9 [Fix] #2477

Jay113355 opened this issue Feb 17, 2016 · 2 comments

Comments

@Jay113355
Copy link

So in this commit: 6e90348 That was added into forge version 1.8.9-11.15.0.1666
Forge/FML started saving dummy block and item entry's into the level.dat.
Line 309 Of the readData method of FMLContainer.java:
if (!regs.getCompoundTag(key).hasKey("dummied")) return;

Checks to see if the dummied tag is present (it is not in 1.8 worlds) if it is not, it then returns thus exiting the reading of the block/item id mappings. (aka level.dat)

This was probably meant to be a continue;.

I've build forge my self and tested the fix. The level.dat is successfully loaded when you change line 309 to if (!regs.getCompoundTag(key).hasKey("dummied")) continue;

@Jay113355
Copy link
Author

Related: #2452

@LexManos
Copy link
Member

This is indeed the case, thanks for catching this. There are other parts where there are issues in the registry code. If you can come up with any other cases where things mess up let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants