Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe loader bails after first bad recipe #4013

Closed
williewillus opened this issue Jun 16, 2017 · 4 comments
Closed

Recipe loader bails after first bad recipe #4013

williewillus opened this issue Jun 16, 2017 · 4 comments
Labels

Comments

@williewillus
Copy link
Contributor

williewillus commented Jun 16, 2017

While testing my autogenerator for jsons, it was extremely annoying that the loader quits loading after the first bad recipe it sees. This means that you have to relaunch the game tens to hundreds of times to see all your errors.

The loader should just skip to the next recipe if parsing one errors, and present all errors to the modder at once.

@BlayTheNinth
Copy link
Contributor

If this is implemented, I would like if it still crashed once all recipes are loaded (instead of only logging to console like models do), because otherwise I can see myself and others missing recipe errors since I only actually check the log when I notice something is wrong.

@mezz mezz added the 1.12 label Jun 17, 2017
@mezz
Copy link
Contributor

mezz commented Jun 22, 2017

Will this be fixed by #4043 or is it a more general issue?
Blay's suggestion (crashing at the end) could be added as a feature after.

@KnightMiner
Copy link
Contributor

I have not tested the PR, but based on it's changes I assume not. The issue here is not whether it crashes or not, but that the recipe loader aborts at the first broken recipe

@Choonster
Copy link
Contributor

This issue is still present in Forge 1.12-14.21.1.2430. PR #4043 wasn't meant to fix this, it was only meant to log an exception instead of crashing the game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants