Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] --modListFile is being ignored on latest builds. #5315

Closed
dscalzi opened this issue Dec 31, 2018 · 1 comment
Closed

[1.12.2] --modListFile is being ignored on latest builds. #5315

dscalzi opened this issue Dec 31, 2018 · 1 comment

Comments

@dscalzi
Copy link

dscalzi commented Dec 31, 2018

  • Verified broken on latest: 1.12.2-14.23.5.2796
  • Last known working: 1.12.2-14.23.2.2651

The --modListFile argument is not working on the latest versions.

I can't immediately tell what's wrong in the code, however the same launch args which worked with the older version noted above are no longer working. The mods are not being loaded.

Related: #5207

Seemingly fixed by 8ace535, however changes were reverted in 10dbbf9

@dscalzi
Copy link
Author

dscalzi commented Dec 31, 2018

After some more digging, I found the issue.

The following line needs to be changed from launchArgs to forgeLaunchArgs.

for (String list : new String[] {"mods/mod_list.json", "mods/" + ForgeVersion.mcVersion + "/mod_list.json", ((Map<String, String>)Launch.blackboard.get("launchArgs")).get("--modListFile")})

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants