Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering title without subtitle through title command crashes #6925

Closed
sciwhiz12 opened this issue Jul 6, 2020 · 1 comment
Closed

Rendering title without subtitle through title command crashes #6925

sciwhiz12 opened this issue Jul 6, 2020 · 1 comment
Labels
1.16 Bug This request reports or fixes a new or existing bug. Regression This request demonstrates something missing in a newer version that was present in a prior version.

Comments

@sciwhiz12
Copy link
Contributor

Minecraft Version: 1.16.1

Forge Version: 32.0.47

Logs: Crash report (ignore the TEST2.zip pack, it's out of scope of this issue)

Steps to Reproduce:

  1. /title @a clear (makes sure that title and subtitle are clear)
  2. /title @a title "Hello"

Description of issue:
When running the title @a title <text> command (any player can be in place of @a, only those players will crash) to render a title on-screen without a previous call to title @a subtitle <text> to record a subtitle to be rendered alongside it, a crash occurs.

The cause is in ForgeIngameGui#renderTitle, the Forge replacement for IngameGui, which does not include null checks for this.displayedSubTitle and this.displayedTitle, which means that not having a recorded subtitle will cause a crash.
displayedTitle should not really be affected, since the title @a title <text> command sets its value and then renders the title immediately after.
IngameGUI has both of these null checks present.

Original bug report on forums

@sciwhiz12 sciwhiz12 added the Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. label Jul 6, 2020
@diesieben07
Copy link
Contributor

#6907

@diesieben07 diesieben07 added 1.16 Bug This request reports or fixes a new or existing bug. Regression This request demonstrates something missing in a newer version that was present in a prior version. and removed Triage This request requires the active attention of the Triage Team. Requires labelling or reviews. labels Jul 6, 2020
@LexManos LexManos closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.16 Bug This request reports or fixes a new or existing bug. Regression This request demonstrates something missing in a newer version that was present in a prior version.
Projects
None yet
Development

No branches or pull requests

3 participants