static import on vanilla class breaks sources jar on non-official mappings

[noeppi-noeppi]

Minecraft Version: 1.20.1

Forge Version: 47.1.0

Description of issue:

ForgeLoadingOverlay.java uses a static import on a vanilla class (import static net.minecraft.util.Mth.clamp;). Since Srg2Source does not support static imports (see MinecraftForge/Srg2Source#28), this is not properly renamed to a SRG name.

Because of this, the published forge sources-jar (https://maven.minecraftforge.net/net/minecraftforge/forge/1.20.1-47.1.0/forge-1.20.1-47.1.0-sources.jar), which should contain everything remapped to SRG won't have this import remapped.

This causes a recompile error when using mappings other than official, as the methods are still named clamp instead of their actual name in the used mapping set.

Proposed solution

Get rid of the static import in ForgeLoadingOverlay.java and write it out as Mth.clamp, so that Srg2Source can properly rename it to its SRG name.