You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Noticed in mc 1.19.2 latest forge. Probably in 1.20 too
Basically if a mod were to (somehow) replace a living entity renderer with one that is not extending LivingEntityRenderer, the event add layer function, when called by another mod, would crash due to unsafe cast incorrectly blaming the latter mod.
Note that my main concern here is my mod (which used add layer event) being blamed and not the other one incase replacing renderers is done incorrectly
The text was updated successfully, but these errors were encountered:
MehVahdJukaar
added
the
Triage
This request requires the active attention of the Triage Team. Requires labelling or reviews.
label
Jul 25, 2023
Your post is very confusing. Would be better if you used the actual class names and/or produced a stacktrace shows the actual issue. But I think I understand what you're talking about. net.minecraftforge.client.event.EntityRenderersEvent.AddLayers.getSkin(Model) and net.minecraftforge.client.event.EntityRenderersEvent.AddLayers.getRenderer(EntityType<? extends T>) have generic return types that extend LivingEntityRenderer where as their backing maps only extend EntityRenderer so if someone were to NOT use the event, and register their renders directly to the vanilla fields somehow, then a class cast exception could be thrown.
Noticed in mc 1.19.2 latest forge. Probably in 1.20 too
Basically if a mod were to (somehow) replace a living entity renderer with one that is not extending LivingEntityRenderer, the event add layer function, when called by another mod, would crash due to unsafe cast incorrectly blaming the latter mod.
Note that my main concern here is my mod (which used add layer event) being blamed and not the other one incase replacing renderers is done incorrectly
The text was updated successfully, but these errors were encountered: