Add option to use additional colors

[ichttt]

This allows to mimic log4j's HighlightConverter more accurate.
By default, it still only highlights errror and warning, info/debug coloring need to be enabled by changing the log4j xml to include a true parameter.
This is useful for forge, as it currently uses log4j's highlight converter (reasoning being the additional colors), which obviously ignored missing ansi support and therefor looks ugly on non-ansi consoles.

[mikroskeem]

Considering that TCA is used by some Minecraft server modifications, then turning INFO level blue by default is not a great idea imho

[ichttt]

First off, coloring below log level warn is disabled by default, you need to set a flag to enable it. Also, this is designed to mimic the log4j highlighter, so I have choosen the same colors as log4j

[mikroskeem]

I'm aware that one needs to set a flag to enable it.

[stephan-gh]

Thanks for your PR!

Originally this was just intended as a simple alternative to Log4j's more complex (but also powerful) %highlight. I think I would rather not make it as powerful.

In general Log4j's HighlightConverter has the noConsoleNoAnsi option. That should work in most cases (disable colors unless running in a proper terminal), but it's a bit more strict. TCA enables colors also for IntelliJ (with some really ugly hacks!), which doesn't report a full console but at least allows console colors.
At least for Forge this could be easily avoided because there is control about the start parameters for IntelliJ. So you could add a system property that disables noConsoleNoAnsi just for IntelliJ and should then have only colors when you really want them.

I think that might be a better solution than editing the HighlightErrorConverter to act exactly like %hilghlight (the name %highlightError gets a bit misleading with this change...).

%highlightError was a pretty bad hack I did back then because I was unable to make Log4j's highlighter aware of the terminal state in TCA. At this point I would rather remove it entirely. That would be quite a bit of work given the amount of projects it is used in.

So, is there any way we can make this work with noConsoleNoAnsi for Forge?

[ichttt]

noConsoleNoAnsi does not work too well, as there are consoles that do not support ansi. So when you use e.g. the windows cmd has a java console, but does not support ansi codes. TCA correctly prints Advanced terminal features are not available in this environment, but l4j uses ansi codes as it found a console...
I still don't see a way to make l4j aware of TCA's state, especially as l4j is initialized very, very early...
And I know highlightError is not an appropiate name, but I didn't want to introduce a breaking change...

[stephan-gh]

Closing in favor of #16.