Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for Compat to 4, (keep existing compat) #170

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Compat package from 3.14 to 3.14, 4.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #170 (e6c4570) into master (1699f6b) will decrease coverage by 0.96%.
The diff coverage is n/a.

❗ Current head e6c4570 differs from pull request most recent head 3777abb. Consider uploading reports for the commit 3777abb to get more accurate results

@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   29.89%   28.92%   -0.97%     
==========================================
  Files          15       15              
  Lines         562      560       -2     
==========================================
- Hits          168      162       -6     
- Misses        394      398       +4     
Impacted Files Coverage Δ
src/Inputs/PWscf/input.jl 70.83% <0.00%> (-8.34%) ⬇️
src/Inputs/PWscf/namelists.jl 81.25% <0.00%> (-1.79%) ⬇️
src/Inputs/PWscf/cards.jl 52.63% <0.00%> (-1.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1699f6b...3777abb. Read the comment docs.

@singularitti singularitti merged commit cff751b into master May 30, 2022
@singularitti singularitti deleted the compathelper/new_version/2022-05-24-00-03-06-605-01300886719 branch May 30, 2022 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant