Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Team.addPlayer() should return an error if used before the player has been configured #2141

Open
KianBrose opened this issue May 17, 2024 · 0 comments

Comments

@KianBrose
Copy link

KianBrose commented May 17, 2024

I recently suffered from an issue where for some reason, even though the player was present in the team's members, it was not present in the playerMembers. It turns out that this was caused due to me adding the player in a pre-configure event that caused the "getPlayers()"'s getOnlinePlayerByUsername to fail as the player was not logged in yet. This would have been very hard to figure out without a debugger. The suggestion as per matt's discord message is to add an error if it's used before the player is configured.

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant