Load heightmaps from anvil files #1917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworzala
added a commit
to hollow-cube/minestom-ce
that referenced
this pull request
Aug 5, 2023
Co-authored-by: tahmid-23 <60953955+tahmid-23@users.noreply.github.com> See Minestom#1917
mworzala
added a commit
to hollow-cube/minestom-ce
that referenced
this pull request
Sep 4, 2023
Co-authored-by: tahmid-23 <60953955+tahmid-23@users.noreply.github.com> See Minestom#1917 (cherry picked from commit ef37e40)
mworzala
added a commit
that referenced
this pull request
Sep 8, 2023
NxDs
pushed a commit
to NxDs/SakuraMinestom
that referenced
this pull request
Oct 10, 2023
Co-authored-by: tahmid-23 <60953955+tahmid-23@users.noreply.github.com> See Minestom#1917 (cherry picked from commit ef37e40)
mworzala
added a commit
that referenced
this pull request
Feb 9, 2024
|
This logic also is impelemented here: #2044. If my pr will be merged this pr probably should be closed |
|
@mworzala this pr can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, heightmaps were hardcoded, which made it rain under surfaces:
With this change, heightmaps are read from anvil files and it no longer rains under surfaces:
In a future commit, the heightmaps will need to be updated on block placement.