Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain offset in BoundingBox::contract and expand #2149

Closed
wants to merge 1 commit into from

Conversation

Minikloon
Copy link
Contributor

This is a breaking change to those methods but I expected those to behave like this so much that I think it's a bug.

@mworzala
Copy link
Member

This is a really 'sneaky' breaking change and would be frustrating to debug. I think there should simply be some new methods added to work this way and javadocs added explaining the difference rather than breaking here.

@Minikloon
Copy link
Contributor Author

I would call them expandInPlace but I think they're pollution.
I'll just
boundingBox.expand(1, 1, 1).withOffset(boundingBox.relativeStart())
forever

@Minikloon Minikloon closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants