Move static Entity lookup maps to EntityTracker #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Putting an entity in an instance which already contains that ID or UUID should throw an exception |
mworzala
reviewed
May 30, 2024
It will from the (using Checks) assertion in EntityTrackerImpl. |
mworzala
approved these changes
Jun 3, 2024
mworzala
force-pushed
the
tracker-entity-maps
branch
from
fdc3091
to
5ba91b4
Compare
mworzala
pushed a commit
that referenced
this pull request
Jun 7, 2024
* Move static Entity lookup maps to EntityTracker * Specific method for changeUuid to keep thread-safety * Fix bug from not recording position on register * Exception on duplicate IDs in the EntityTracker * Oops, expected stateCondition to behave like assert * Didn't mean to make Entity::remove(boolean) public * More descriptive EntityView::register error * Warn when attempting to move untracked entity
mworzala
pushed a commit
that referenced
this pull request
Jun 8, 2024
* Move static Entity lookup maps to EntityTracker * Specific method for changeUuid to keep thread-safety * Fix bug from not recording position on register * Exception on duplicate IDs in the EntityTracker * Oops, expected stateCondition to behave like assert * Didn't mean to make Entity::remove(boolean) public * More descriptive EntityView::register error * Warn when attempting to move untracked entity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityTrackerEntry exists to ensure the same behavior as before in regards to the recorded position in the tracker.