Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): rename onError to onInvalid #9

Merged
merged 4 commits into from
Dec 18, 2022
Merged

Conversation

Mini-ghost
Copy link
Owner

πŸ”— Linked issue

No issues linked to this PR

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Renamed the current error handler onError to onInvalid, and onError will be removed in major releases. This change references the naming of the HTML Standard #event-invalid.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@netlify
Copy link

netlify bot commented Dec 15, 2022

βœ… Deploy Preview for vorms ready!

Name Link
πŸ”¨ Latest commit
πŸ” Latest deploy log https://app.netlify.com/sites/vorms/deploys/639b40392e3e773209f73179
😎 Deploy Preview https://deploy-preview-9--vorms.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@Rock070 Rock070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mini-ghost Mini-ghost self-assigned this Dec 16, 2022
@Mini-ghost Mini-ghost merged commit daf589b into main Dec 18, 2022
@Mini-ghost Mini-ghost deleted the feat/invalid-event branch January 11, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants