Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use thelounge internals #31

Closed
wants to merge 1 commit into from

Conversation

brunnre8
Copy link
Collaborator

This needs the plugin improvements of TL

This needs the plugin improvements of TL
@brunnre8
Copy link
Collaborator Author

This is in draft state until thelounge/thelounge#4329 is figured out

@MiniDigger
Copy link
Owner

looks good!

@brunnre8
Copy link
Collaborator Author

Considering that you don't use TL anymore, are you still willing to maintain your TL plugins or would you prefer if someone else takes over maintenance in a fork or something?

@MiniDigger
Copy link
Owner

if you want to take over, that would be cool! I can add you to this repo, it should be still setup to automatically publish to NPM.
not sure if its possible to publish to NPM from another user to the existing package, but we can look into that too if you want to have your own repo instead (I would archive this and point it to the fork)

@brunnre8
Copy link
Collaborator Author

brunnre8 commented Oct 13, 2021

well, "want" is a hard word 😜
It'd be sad to see the plugin become orphaned and non functional after you've put quite a bit of work in it and are the poster child when someone asks about plugins.

I'd be happy to keep this in your personal namespace if you wish, attribution wise, but I can also understand if you'd rather not.

So long story short, yes, I'd be willing to maintain it.
If you want to keep this here I'd appreciate the access and if you'd rather have me fork it and link to it we can do that.
The choice is completely yours.

@MiniDigger
Copy link
Owner

MiniDigger commented Oct 13, 2021

granted you access. creating a NPM release you can do here on github by going to "Releases" -> "Draft new release", creating a new tag in the "choose tag" dropdown, adding a title and some body and then github will automatically bump the version and deploy to npm for you.
ill be always around tho and still look at stuff

@MiniDigger MiniDigger mentioned this pull request Oct 20, 2021
@brunnre8
Copy link
Collaborator Author

brunnre8 commented Dec 4, 2021

6c87c5d

@brunnre8 brunnre8 closed this Dec 4, 2021
@brunnre8 brunnre8 deleted the noInternals branch December 4, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants