New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it work #1

Merged

4drian3d merged 2 commits into MiniPlaceholders:main from Sliman4:make-it-work

Oct 17, 2022

Contributor

Sliman4 commented Oct 17, 2022

I don't know what the name of this PR should be, it does a lot of things

Renamed project name to LuckPerms-Expansion
Renamed package name to me.dreamerzero.luckpermsexpansion
Added gradle wrapper so people know how to compile this
MiniPlaceholders 1.3.1 support
Removed in_group placeholder which was incorrect

LuckPerms-Expansion/paper/src/main/java/me/dreamerzero/example/paper/PaperPlugin.java

Line 76 in 91216bf

if(group != null) return Tag.selfClosingInserting(FALSE_COMPONENT);

and does the same thing as inherits_group, or maybe I don't understand something. MiniPlaceholders wiki should be updated if this change gets merged. And btw I think the wiki should say something about arguments in placeholders like <luckperms_inherits_group:group>, not just <luckperms_inherits_group>
Listed all placeholders in README.md

Sliman4 added 2 commits

October 17, 2022 17:42


          Update to MiniPlaceholders 1.3.1, change project and package name, re…

9e58da3

…move incorrect and redundant luckperms_in_group placeholder


          Fix indentation

571607e

4drian3d approved these changes

View reviewed changes

4drian3d merged commit 0529ff8 into MiniPlaceholders:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment