Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages from repository and use NuGet package restore #52

Closed
TrevorPilley opened this issue May 2, 2014 · 3 comments
Closed
Assignees

Comments

@TrevorPilley
Copy link
Contributor

Having the packages in the repository adds considerable size to the repository and can introduce annoying merge conflicts with dll files. It also bloats commits when adding/updating packages.

Is there a good reason to have them in source?

@yellis yellis self-assigned this May 7, 2014
@yellis
Copy link
Member

yellis commented May 7, 2014

The original reason for this is because at one point there were some internal (to StackExchange) nugets being used in building the repository, and storing all of the packages in the repo was the best way to guarantee that we were always building it the way that we wanted.

However, for quite some time we have been consuming only public nugets, so as you point out, there is no reason anymore to save /packages.

Before I gut these out, I need to make sure that our internal builds are able to retrieve the nugets and build properly. It is on my todo list, I will update here when this is ready.

@TrevorPilley
Copy link
Contributor Author

OK sounds good, the only slight annoyance I've encountered by using package restore is that you can sometimes get old versions left in /packages on the build server which need manually deleting.

yellis added a commit that referenced this issue May 11, 2014
yellis added a commit that referenced this issue May 11, 2014
Packages are no longer saved in the repo (#52)
@yellis yellis closed this as completed May 11, 2014
@yellis
Copy link
Member

yellis commented May 11, 2014

Packages are gone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants