Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AspDotNetCore.md to add Memory Cache #525

Closed
wants to merge 1 commit into from

Conversation

ceemafour
Copy link

Add required step to add services.AddMemoryCache() which is essential for MiniProfiler to work in .Net Core

Add required step to add services.AddMemoryCache() which is essential for MiniProfiler to work in .Net Core
@NickCraver
Copy link
Member

@ceemafour This should not be needed since 4.2.1 (see release notes: https://miniprofiler.com/dotnet/Releases) - are you still encountering a case where it is?

@ceemafour
Copy link
Author

Yes it’s still happening. Downloaded the nuget 4.2.1 today and ran into this issue.

@NickCraver
Copy link
Member

@ceemafour we should look at your config - what error is happening? Note from the examples - it should not be needed: https://github.com/MiniProfiler/dotnet/blob/main/samples/Samples.AspNetCore3/Startup.cs#L34 - they run just fine. I'd like too understand what's different about your scenario that it's not behaving, rather than adjusting the docs. There's a bug here if you still need this.

@NickCraver
Copy link
Member

Closing this out to cleanup!

@NickCraver NickCraver closed this Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants