Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give an option to precompile includes.css #60

Closed
Crystark opened this issue Mar 5, 2014 · 8 comments
Closed

Give an option to precompile includes.css #60

Crystark opened this issue Mar 5, 2014 · 8 comments

Comments

@Crystark
Copy link

Crystark commented Mar 5, 2014

Hi,

In our production environment, the following file returns a 404: /mini-profiler-resources/includes.css

The reason to this is that all our static resources (css, js, images...) are managed by a content delivery server that catches the requests based on the extension of the file and fetches the file directly on disc to optimize the delivery of those.
As includes.css isn't actually in the assets directory, it fails to fetch it.

Would it be possible to give an option to allow this file to be precompiled alongside the other CSS files when using rake assets:precompile ?

Thanks

@SamSaffron
Copy link
Member

I open for an extra option here, care to try out a PR?

@Crystark
Copy link
Author

Crystark commented Mar 6, 2014

I'm really unsure on how to do so and not break anything here.
I may be able to follow http://prioritized.net/blog/gemify-assets-for-rails/ but it would mean reviewing the directory layout of your project and i wouldn't know how to efficiently test it then.

@pencilcheck
Copy link

+1

@5minpause
Copy link

+1
Is there any development for this issue?
Would it be an option to include the .css files in the assets pipeline if present?

@stiller-leser
Copy link

Has there been any work on this issue? We are facing the same issue when trying to integrate the profiler into an Rails-app with asset-pipeline. It won't get the include.js - had a look at gemifying it, but there are a lot of changes needed. Hard to do, if you don't know the code that well.

@SamSaffron
Copy link
Member

totally open to allowing the assets to be included via sprockets, it should be fairly straight forward to just move stuff around a bit to make this workable no?

@factcondenser
Copy link

I believe this issue has been addressed per the merged PR mentioned above ☝️. @SamSaffron - should be safe to close this issue unless anyone objects?

@SamSaffron
Copy link
Member

thanks @factcondenser closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants