Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning with Rack >= 3.0.0 - Rack::File is deprecated and will be removed in Rack 3.1 #600

Closed
mmcnickle-float opened this issue Dec 7, 2023 · 0 comments · Fixed by #604

Comments

@mmcnickle-float
Copy link

Rack::File will be deprecated in Rack 3.1 (rack/rack#1811). There's been a compatibility layer in place that renames Rack::File to Rack::Files to help the transition since Rack 2.1.0 (https://github.com/rack/rack/blob/main/CHANGELOG.md#210---2020-01-10)

At the minute, the Gemspec gives the compatibility of Rack of >= 1.2.0

I guess there are two approaches to how to resolve this:

  1. Change the minimum compatible Rack version to >= 2.1.0 and change the call at https://github.com/MiniProfiler/rack-mini-profiler/blob/master/lib/mini_profiler/actions.rb#L58 to use Rack::Files instead.
  2. Keep the minimum compatible Rack version at >= 1.2.0 and write a compatibility check/layer in this gem instead.

I'm not sure which approach the project maintainer prefers?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant