Fixing invalid X-MiniProfiler-Ids responses

[SeriousM]

Sometimes the X-MiniProfiler-Ids response contains a double-array instead of a single.
With this change, we take the first one and discard the rest.

A normal response looks like that:

["94A4A68F-C2C5-4A66-8369-CC5DAAEF3640"]

Sometimes I get this response:

["94A4A68F-C2C5-4A66-8369-CC5DAAEF3640"], ["94A4A68F-C2C5-4A66-8369-CC5DAAEF3640"]

I do not know why, but this is a fix/workaround for that.

Edit:
I forgot to mention that all the id-parsings now also bundled in one method.

[dixon]

Hmm, which language are you using? It sounds like a bug in one of the server implementations - the client should expect well-formed responses from the server.

[SeriousM]

I'm using .net mvc4.
The Double-Response appeared with the official miniprofiler package as well
with the current source I build today.
Used packages: miniprofiler, miniprofiler.ef, miniprofiler.mvc3

[yellis]

@SeriousM any chance you can see if you can replicate it using the code in the dotnet repo? The code in the nugets you used is from version 2.x - code up here right now is from version 3.x (new nugets imminent)

[SeriousM]

Yes I was able to reproduce the situation with the current source.
Can I help you further?

[yellis]

Can you post code or a fork that reproduces this?

[SeriousM]

I can give you the relevant code examples.

public static void PreStart(bool autoShow)
{
    MiniProfiler.Settings.SqlFormatter = new StackExchange.Profiling.SqlFormatters.SqlServerFormatter();

    MiniProfiler.Settings.ExcludeStackTraceSnippetFromCustomTimings = false;
    MiniProfiler.Settings.StackMaxLength = 1000;

    MiniProfiler.Settings.TrivialDurationThresholdMilliseconds = 3;

    MiniProfiler.Settings.IgnoredPaths = 
        new[]
            {
                "/content/", "/scripts/", "/favicon.ico", "/images/", "/viewscripts/"
            };

    MiniProfilerEF.InitializeEF42(false);

    GlobalFilters.Filters.Add(new ProfilingActionFilter());

    MiniProfiler.Settings.PopupShowTrivial = false;
    MiniProfiler.Settings.PopupRenderPosition = RenderPosition.Right;
    MiniProfiler.Settings.PopupMaxTracesToShow = 50;
    MiniProfiler.Settings.ShowControls = autoShow;
    MiniProfiler.Settings.PopupShowTimeWithChildren = true;
}

public static void PostStart()
{
    var copy = ViewEngines.Engines.ToList();
    ViewEngines.Engines.Clear();
    foreach (var item in copy)
    {
        ViewEngines.Engines.Add(new ProfilingViewEngine(item));
    }
}

static void OnBeginRequest(HttpRequest request)
{
    if (request.IsLocal)
    {
        MiniProfiler.Start();
    }
}

public static void OnEndRequest()
{
    MiniProfiler.Stop();
}

I call these functions on my own during the app-startup, not via the attributes.

Is that enough?

[SeriousM]

any updates on this issue?

[SeriousM]

bump?

[jcoutch]

Has any progress been made towards fixing this bug? We're also experiencing it in our ASP.NET MVC 4 application.

[maddyblue]

Please move this issue to https://github.com/MiniProfiler/dotnet.

[SeriousM]

Due my current situation (changed company + project) I'm not interested in the solution anymore. @jcoutch, can you take the responsibility?

[jcoutch]

@SeriousM - Sorry for the delay...been busy the past couple months. Sure, I'll move it over to the dotnet project and follow up.