Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some languages not found #4

Closed
agonzalezd opened this issue Sep 2, 2022 · 3 comments
Closed

Some languages not found #4

agonzalezd opened this issue Sep 2, 2022 · 3 comments

Comments

@agonzalezd
Copy link

First of all, thanks for the repository, it may result very helpful.

I am having some issues, though. I installed the repository via pip. I tried to check for Iberian languages, and surprisingly not Catalan nor Asturian were loaded:

>>> from phones import PhoneCollection
>>> pc = PhoneCollection()
>>> pc.langs('cat').values
[]
>>> pc.langs('ast').values
[]

I checked the .csv file the program is using from phoible (https://raw.githubusercontent.com/phoible/dev/master/data/phoible.csv) and both Asturian and Catalan are present, with those ISO codes (cat and ast). I don't know which could be the problem in this case. I imagine it could be related to the names of the dialects in some way.

Thanks in advance

@MiniXC
Copy link
Owner

MiniXC commented Sep 2, 2022

Thanks for raising this issue, fortunately it's an easy fix!

from phones import PhoneCollection
pc = PhoneCollection(drop_dialects=False)
pc.langs("cat").values

The problem here is that both languages don't have any entries without a "dialect" label in PHOIBLE, they obviously aren't dialects! I will have to add a filter for dialects, but for now, the solution above will work, although it will combine Western and North-Eastern Asturian, for example.

@MiniXC MiniXC mentioned this issue Sep 2, 2022
@agonzalezd
Copy link
Author

Even though I am getting the phonemes for Catalan, those from Asturian are still missing... However, I saw that you opened a new issue #5 so I guess you are working on this :)

@MiniXC
Copy link
Owner

MiniXC commented Sep 7, 2022

Thanks for pointing this out, it has been fixed in 0.0.3!
You can see an example of the new API for dialects here (scroll all the way to the bottom): https://cdminix.me/phones/examples/basic_usage/

@MiniXC MiniXC closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants