Add a better way to handle http exceptions #7
Conversation
|
Isn't the PR you did exactly the same as it was before? |
| private final String body; | ||
|
|
||
| public HttpException(int code, @NotNull String body) { | ||
| super("Request returned failure " + code + ": " + body); |
There was a problem hiding this comment.
Maybe it makes sense to exclude the body from the message if its otherwise accessible
There was a problem hiding this comment.
Isn't the PR you did exactly the same as it was before?
Sending the messageRequest returned failure <code>: <body>
I excluded body & code from message in http exception, as @MinnDevelopment metioned. If user will log exception, message will remain the same as it was before. But if you catch it you're able to access exception body & code. For example now im able to catch 401 exceptions, when token is incorrect.
Can you tell me what to comment on? I'm quite new in open source and from my perspective there is not much to comment on here, only the constructor has changed and 2 getters have been added.
There was a problem hiding this comment.
I mean that you comment what the getters will return. Like this
|
I created documentation for new code, but i still think that docs for simple getters in exception are redundant. |
If something goes wrong while sending a message to the webhook, e.g. the token is incorrect. WebhookClient throws an exception with a message from which it is difficult to extract e.g. an error code. Pull request changes it so that error handling is simpler.