[camera] Fixed stale images in imageStream subscriptions (flutter#3344)

* Fixed stale images in imageStream subscriptions * Implemented feedback * Fixed format exception * added null-check for imageStreamReader * Removed setOnImageAvailableListener from onCancel * fixed formatting
Minyewoo · Jan 12, 2021 · b9770d8 · b9770d8
1 parent 7b07f0f
commit b9770d8
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 2 deletions.
diff --git a/packages/camera/camera/CHANGELOG.md b/packages/camera/camera/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.6.4+2
+
+* Set ImageStreamReader listener to null to prevent stale images when streaming images. 
+
 ## 0.6.4+1
 
 * Added closeCaptureSession() to stopVideoRecording in Camera.java to fix an Android 6 crash

diff --git a/packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java b/packages/camera/camera/android/src/main/java/io/flutter/plugins/camera/Camera.java
@@ -1111,6 +1111,13 @@ public void setZoomLevel(@NonNull final Result result, float zoom) throws Camera
     result.success(null);
   }
 
+  public void stopImageStream() throws CameraAccessException {
+    if (imageStreamReader != null) {
+      imageStreamReader.setOnImageAvailableListener(null, null);
+    }
+    startPreview();
+  }
+
   private void closeCaptureSession() {
     if (cameraCaptureSession != null) {
       cameraCaptureSession.close();

diff --git a/.../camera/camera/android/src/main/java/io/flutter/plugins/camera/MethodCallHandlerImpl.java b/.../camera/camera/android/src/main/java/io/flutter/plugins/camera/MethodCallHandlerImpl.java
@@ -287,7 +287,7 @@ public void onMethodCall(@NonNull MethodCall call, @NonNull final Result result)
       case "stopImageStream":
         {
           try {
-            camera.startPreview();
+            camera.stopImageStream();
             result.success(null);
           } catch (Exception e) {
             handleException(e, result);

diff --git a/packages/camera/camera/pubspec.yaml b/packages/camera/camera/pubspec.yaml
@@ -6,7 +6,7 @@ description: A Flutter plugin for getting information about and controlling the
 
 
 
-version: 0.6.4+1
+version: 0.6.4+2
 homepage: https://github.com/flutter/plugins/tree/master/packages/camera/camera
 dependencies:
   flutter: