Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css issues when using a really old punbb mod (.pun fieldset .rbox input and .pun fieldset .rbox br css rules) #28

Open
Dwedit opened this issue May 20, 2023 · 6 comments

Comments

@Dwedit
Copy link

Dwedit commented May 20, 2023

In the style .css files, there is a rule applied:

.pun fieldset .rbox input {
	margin: 0 9px 0 -25px;
	padding: 0;
	width: 16px;
	position: relative;
	vertical-align: middle;
}

But I had an issue with this. I was re-integrating some old code for the Punbb Attachment Mod 2.0, which makes use of input tags which aren't checkboxes, and places them inside of the rbox div. You get a tiny 16x16 button that's not properly labeled as "Browse...", and it is positioned in a bad location from the margin rule.

If you make the rule apply only to checkboxes by using .pun fieldset .rbox input[type="checkbox"] {, then only checkboxes get shrunken down to 16px and have their margin changed.

The other CSS issue I encountered was this one:

.pun fieldset .rbox br {
	display: none;
}

This forcefully removes the line breaks used by the attachment mod, so I had to comment this rule out.

MioVisman added a commit that referenced this issue May 21, 2023
@MioVisman
Copy link
Owner

Thank you! Slightly changed. Added condition for type="radio" too.

@Dwedit
Copy link
Author

Dwedit commented May 24, 2023

Also one other issue I encountered:

The math captcha can turn the "-" symbol into "to reduce". But that's not standard English for subtraction at all, I had no idea what it meant until I read the source code. "Reduce" is something you do to a fraction, like changing 5/10 into 1/2. I'd replace "to reduce" with "subtract".

MioVisman added a commit that referenced this issue May 25, 2023
@MioVisman
Copy link
Owner

Ok. I use google translate to write in english. It is he who offers translation options.

@Dwedit
Copy link
Author

Dwedit commented May 30, 2023

Caught another CSS bug...

.pun label {
	display: block;
	padding: 3px 0;
}

Having display: block; in there puts in a line break in between the "Jump To" combobox and the "Go" button. They are supposed to be on the same line.

I changed it to this:

.pun label :not(#qjump) :not(#qjump2) {
	display: block;
}

.pun label {
	padding: 3px 0;
}

MioVisman added a commit that referenced this issue May 31, 2023
@MioVisman
Copy link
Owner

.pun label :not(#qjump) :not(#qjump2)

This is not true.
I added this rule:

#qjump > div > label, #qjump2 > div > label {
	display: inline-block;
}

@MioVisman
Copy link
Owner

and
e892b03
77358b3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants