Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not close xterm when launched by Mir #1284

Closed
wmww opened this issue Feb 14, 2020 · 9 comments · Fixed by #2541 or #2562
Closed

Can not close xterm when launched by Mir #1284

wmww opened this issue Feb 14, 2020 · 9 comments · Fixed by #2541 or #2562
Assignees
@AlanGriffiths
Labels
bug XWayland

Comments

@wmww
Copy link
Contributor

wmww commented Feb 14, 2020 •
edited

If xterm is launched with Ctrl+Alt+X, clicking the X on the SSDs does nothing. If it is launched externally, it closes the window as you would expect.
@wmww wmww added the XWayland label Feb 14, 2020
@wmww
Copy link
Contributor Author

wmww commented Feb 14, 2020

It's sending the correct WM_DELETE_WINDOW request in both cases. Kate, Gedit, PCManFM and xeyes all close fine when launched via external_client_launcher.launch_using_x11(). No clue what's going on here.

@wmww
Copy link
Contributor Author

wmww commented Feb 14, 2020

It seems to be passed down through the environment or a similar process (xterms launched by a mir-launched xterm also can't close), but I can't reproduce with an externally launched terminal even after copying all possibly relevant variables from the environment reported by the xterm launched from Mir.

@AlanGriffiths
Copy link
Contributor

How about xterm launched from a Mir launched gnome-terminal?

PS This must be recent, I've been doing this all week.

@wmww
Copy link
Contributor Author

wmww commented Feb 15, 2020 •
edited

Good idea, I'm curious

EDIT: xterm launched from a Mir launched gnome-terminal (and xterms launched from it) can be closed normally.

EDIT2: if you do Ctrl+Alt+X (opens xterm) -> $ gnome-terminal (runs on wayland) -> $ xterm you can close the 2nd xterm but not the original one.

EDIT3: works even if the intermediary terminal is lxterminal running on X11 (no Wayland apps involved). If all the terminals in the chain are xterms however, they all still fail to close.

@AlanGriffiths
Copy link
Contributor

AlanGriffiths commented Feb 17, 2020 •
edited

I cannot reproduce this on 18.04.

Reproduced on 20.04.

@AlanGriffiths
Copy link
Contributor

Reproduced on 20.04.

Still happening. Weird that the way it is launched affects using the X icon.

@AlanGriffiths
Copy link
Contributor

AlanGriffiths commented Aug 8, 2022 •
edited

Still happens on 22.04

And, interestingly, launching with "sh -c xterm" doesn't exhibit a problem.

@AlanGriffiths
Copy link
Contributor

And, interestingly, launching with "sh -c xterm" doesn't exhibit a problem.

On the other hand sh -c 'exec xterm' does exhibit the problem. I suspect this something carried over through fork/exec. (e.g. signal handling)

@AlanGriffiths AlanGriffiths self-assigned this Aug 8, 2022
@AlanGriffiths
Copy link
Contributor

Confirmed: killall xterm doesn't work for the xterm started by Mir

@AlanGriffiths AlanGriffiths mentioned this issue Aug 9, 2022
Merged
bors bot added a commit that referenced this issue Aug 9, 2022
@bors @AlanGriffiths
Merge #2541
84905e8 
2541: [miral] Unblock signals before execing child processes r=Saviq a=AlanGriffiths

Fixes: #1284

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
@bors bors bot closed this as completed in f02264b Aug 9, 2022
@AlanGriffiths AlanGriffiths mentioned this issue Aug 18, 2022
Merged
bors bot added a commit that referenced this issue Aug 30, 2022
@bors @AlanGriffiths
Merge #2562
06d3144 
2562: Release 2.9.0 r=AlanGriffiths a=AlanGriffiths

## ABI summary:
* miral ABI bumped to 5
* mircommon ABI unchanged at 9
* mircookie ABI unchanged at 2
* mircore ABI bumped to 2
* miroil ABI bumped to 2
* mirplatform ABI unchanged at 23
* mirserver ABI unchanged at 58
* mirwayland ABI unchanged at 3
* mirplatformgraphics ABI unchanged at 20
* mirinputplatform ABI unchanged at 8
## Enhancements:
* [Wayland] Implement zwp_idle_inhibit_manager_v1
* [Wayland] Implement zwlr_virtual_pointer_v1
* [Wayland] Implement zwp_text_input_manager_v1 (Electron works with OSK)
* [Wayland] Bump wl_seat to v8 and implement hi-res scrolling (Fixes: #2176, Fixes: #2499)
* [Wayland platform] improve failed to connect error
* [Wayland platform] Port to xdg-shell (Fixes #1903, Fixes: #2434)
* [MirAL] Allow `--add-wayland-extenions all`
* [MirAL] Allow servers to get repeated string options
* [MirAL] Improvement to ExternalClientLauncher: Don't force clients to split command lines themselves
* [MirAL] Tidy up event filtering API
* [MirAL] Expose miral::Zone::id()
* [Input] Filter 2 distinct bogus touch event scenarios (UBports)
* [gbm-kms] new driver quirk to disable KMS modeset probe
* [gbm-kms] Add defaults to driver-quirks for nvidia and evdi (Fixes: #2467)
* [gbm-kms] Add defaults to driver-quirks for vc4-drm and v3d
* [mir-smoke-test-runner] Enable working in a Wayland only environment
## Bugs fixed:
* Fix ABI breakage of libmircore.so.1 with v2.8.0 vs v1.8.2 (Fixes #2465)
* [Wayland] Text Input v2: do not use commit count as serial
* [Wayland] Send keyboard modifiers after keyboard enter (Fixes: #2535, Fixes: #2025)
* [Wayland] wlr-screencopy-v1: send .damage event as required (wayvnc fix)
* [Wayland] wlr-screencopy-v1: Waits until the copy area has been damaged in `.copy_with_damage` request (wayvnc fix)
* [MirAL] Unblock signals before execing child processes (Fixes: #1284)
* [eglstream-kms] Kill clients, not Mir, when they submit bad EGLStreams (Fixes: #2061)
* [eglstream-kms] Handle EGL errors in devnum_for_device (Fixes: #2426)
* [test clients] Explicitly ask for a GLESv2 context (Fixes: #2440)
* [renderers/gl] Clear framebuffer to opaque black (Fixes: #2427)
* CMake cleanup for locally built dependencies (Fixes: #2507, Fixes: #2261)
* Fix event timestamps (Fixes: #2577)

Co-authored-by: Alan Griffiths <alan@octopull.co.uk>
Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanGriffiths AlanGriffiths

Labels
bug XWayland
Projects
None yet
Milestone
No milestone
2 participants
@AlanGriffiths @wmww