Release 2.9.0 #2562

AlanGriffiths · 2022-08-17T10:25:16Z

ABI summary:

miral ABI bumped to 5
mircommon ABI unchanged at 9
mircookie ABI unchanged at 2
mircore ABI bumped to 2
miroil ABI bumped to 2
mirplatform ABI unchanged at 23
mirserver ABI unchanged at 58
mirwayland ABI unchanged at 3
mirplatformgraphics ABI unchanged at 20
mirinputplatform ABI unchanged at 8

Enhancements:

[Wayland] Implement zwp_idle_inhibit_manager_v1
[Wayland] Implement zwlr_virtual_pointer_v1
[Wayland] Implement zwp_text_input_manager_v1 (Electron works with OSK)
[Wayland] Bump wl_seat to v8 and implement hi-res scrolling (Fixes: Implement discrete scrolling for mouse wheel #2176, Fixes: Upgrade to wl_seat v7 #2499)
[Wayland platform] improve failed to connect error
[Wayland platform] Port to xdg-shell (Fixes [Mir-on-Wayland] On GNOME/Wayland all windows open on first monitor #1903, Fixes: Failing to run Wayland platform on hosts that don't support wl-shell #2434)
[MirAL] Allow --add-wayland-extenions all
[MirAL] Allow servers to get repeated string options
[MirAL] Improvement to ExternalClientLauncher: Don't force clients to split command lines themselves
[MirAL] Tidy up event filtering API
[MirAL] Expose miral::Zone::id()
[Input] Filter 2 distinct bogus touch event scenarios (UBports)
[gbm-kms] new driver quirk to disable KMS modeset probe
[gbm-kms] Add defaults to driver-quirks for nvidia and evdi (Fixes: Auto-selection of X11 platforms fails with Nvidia drivers (470 and 515) using LXDE #2467)
[gbm-kms] Add defaults to driver-quirks for vc4-drm and v3d
[mir-smoke-test-runner] Enable working in a Wayland only environment

Bugs fixed:

Fix ABI breakage of libmircore.so.1 with v2.8.0 vs v1.8.2 (Fixes ABI breakage of libmircore.so.1 with v2.8.0 vs v1.8.2 #2465)
[Wayland] Text Input v2: do not use commit count as serial
[Wayland] Send keyboard modifiers after keyboard enter (Fixes: Send keyboard modifiers after keyboard enter #2535, Fixes: Keyboard modifier state gets out of sync #2025)
[Wayland] wlr-screencopy-v1: send .damage event as required (wayvnc fix)
[Wayland] wlr-screencopy-v1: Waits until the copy area has been damaged in .copy_with_damage request (wayvnc fix)
[MirAL] Unblock signals before execing child processes (Fixes: Can not close xterm when launched by Mir #1284)
[eglstream-kms] Kill clients, not Mir, when they submit bad EGLStreams (Fixes: [eglstream-kms] GLX clients in XWayland crash Mir #2061)
[eglstream-kms] Handle EGL errors in devnum_for_device (Fixes: Hybrid AMD/NVIDIA system fails #2426)
[test clients] Explicitly ask for a GLESv2 context (Fixes: Wayland client doesn't explicitly ask for a GLESv2 context #2440)
[renderers/gl] Clear framebuffer to opaque black (Fixes: Screenshotting and background #2427)
CMake cleanup for locally built dependencies (Fixes: Mir tries to link clients with wrong Wayland libraries since Cmake 3.22+ #2507, Fixes: Mir fails to build with Wayland master, and cmake v3.22.0, linking with wl_proxy_marshal_flags #2261)
Fix event timestamps (Fixes: [2.9] Weird scrolling in, for example Firefox #2577)

RAOF · 2022-08-19T08:15:55Z

Looks like #2565 should be easy to fix?

AlanGriffiths · 2022-08-19T08:17:08Z

Looks like #2565 should be easy to fix?

Should be. I'll have a look...

AlanGriffiths · 2022-08-19T09:42:24Z

Looks like #2565 should be easy to fix?

Not as trivial as I first thought. The logic is plain wrong, and the tests test match. But tractable.

2566: Handle the new libinput events r=Saviq,RAOF a=AlanGriffiths Do not conflate `LIBINPUT_EVENT_POINTER_AXIS` with `LIBINPUT_EVENT_POINTER_SCROLL_WHEEL` etc. Fixes: #2565 Co-authored-by: Alan Griffiths <alan@octopull.co.uk> Co-authored-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com> Co-authored-by: Sophie Winter <wm@wmww.sh>

2574: Fix include guard r=Saviq a=AlanGriffiths Oops! Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

2575: Rename miral::CommandLineOption to ConfigurationOption r=Saviq a=AlanGriffiths Candidate for cherry-picking to 2.9 as we've already broken ABI Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

2589: [Wayland platform] Don't use uses EGL 1.5 entry points r=Saviq a=AlanGriffiths Fixes: #2570 Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

Saviq · 2022-08-26T07:20:23Z

Having cherry-picked a few low risk items I think this will be it.

We need to make a call on #2590 - I'm testing it now.

Otherwise, the lab likes ~rc6 just fine.

AlanGriffiths · 2022-08-26T07:58:41Z

We need to make a call on #2590 - I'm testing it now.

Agreed. Three things about that:

does it work? (that seems likely)
does it do the right thing? (that's my principle concern)
should we bundle it (and, potentially, other fixes) in 2.9.1?

Saviq · 2022-08-26T08:23:16Z

does it work? (that seems likely)

Works for me.

does it do the right thing? (that's my principle concern)

I'll leave that for you to decide.

should we bundle it (and, potentially, other fixes) in 2.9.1?

Or a 2.10 - none of these are regressions I don't think. We may just do a 2.10 sooner than later.

2590: Fix timestamp calibration r=AlanGriffiths a=wmww Fixes #2577 Prevent timestamps in the future ever being sent, and use unmodified timestamps if they're close to Mir's internal timestamps. Co-authored-by: Sophie Winter <wm@wmww.sh>

Saviq · 2022-08-26T10:17:04Z

rc8

With a fix to #2577. And a good changelog.

Debs

Test plan: https://wiki.ubuntu.com/Process/Merges/TestPlans/Mir

Installed from from ppa:mir-team/rc

Platform	22.04LTS	20.04LTS	22.10
gbm-kms	@Saviq	@AlanGriffiths	@AlanGriffiths
X11		@AlanGriffiths	@AlanGriffiths
Wayland	@Saviq	@AlanGriffiths	@AlanGriffiths
eglstream-kms
dispmanx

Console	22.04LTS	20.04LTS	22.10
minimal		@AlanGriffiths	@AlanGriffiths
linux-VT		@AlanGriffiths
logind	@Saviq	@AlanGriffiths	@AlanGriffiths

WM	22.04LTS	20.04LTS	22.10
floating	@Saviq	@AlanGriffiths	@AlanGriffiths
tiling		@AlanGriffiths	@AlanGriffiths
kiosk		@AlanGriffiths	@AlanGriffiths

AlanGriffiths · 2022-08-30T14:10:48Z

bors merge

bors · 2022-08-30T14:45:19Z

Build succeeded:

AlanGriffiths added 2 commits August 17, 2022 11:23

Draft changelog

67638a7

Draft changelog

e81ca2a

This comment was marked as outdated.

Sign in to view

AlanGriffiths mentioned this pull request Aug 17, 2022

We don't get a clear diagnostic when we have no active outputs #2563

Open

AlanGriffiths marked this pull request as ready for review August 18, 2022 09:34

This comment was marked as outdated.

Sign in to view

bors bot and others added 3 commits August 24, 2022 10:50

Merge #2574

bad566c

2574: Fix include guard r=Saviq a=AlanGriffiths Oops! Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

Merge #2575

878ea23

2575: Rename miral::CommandLineOption to ConfigurationOption r=Saviq a=AlanGriffiths Candidate for cherry-picking to 2.9 as we've already broken ABI Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

Merge #2589

a78a870

2589: [Wayland platform] Don't use uses EGL 1.5 entry points r=Saviq a=AlanGriffiths Fixes: #2570 Co-authored-by: Alan Griffiths <alan@octopull.co.uk>

This comment was marked as outdated.

Sign in to view

Merge #2590

22d52f1

2590: Fix timestamp calibration r=AlanGriffiths a=wmww Fixes #2577 Prevent timestamps in the future ever being sent, and use unmodified timestamps if they're close to Mir's internal timestamps. Co-authored-by: Sophie Winter <wm@wmww.sh>

This comment was marked as outdated.

Sign in to view

Changelog

3811e4d

bors bot merged commit 06d3144 into main Aug 30, 2022

bors bot deleted the release/2.9 branch August 30, 2022 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 2.9.0 #2562

Release 2.9.0 #2562

AlanGriffiths commented Aug 17, 2022 •

edited by Saviq

This comment was marked as outdated.

RAOF commented Aug 19, 2022

AlanGriffiths commented Aug 19, 2022

AlanGriffiths commented Aug 19, 2022

This comment was marked as outdated.

This comment was marked as outdated.

Saviq commented Aug 26, 2022

AlanGriffiths commented Aug 26, 2022

Saviq commented Aug 26, 2022 •

edited

This comment was marked as outdated.

Saviq commented Aug 26, 2022 •

edited by AlanGriffiths

AlanGriffiths commented Aug 30, 2022

bors bot commented Aug 30, 2022

Release 2.9.0 #2562

Release 2.9.0 #2562

Conversation

AlanGriffiths commented Aug 17, 2022 • edited by Saviq

ABI summary:

Enhancements:

Bugs fixed:

This comment was marked as outdated.

RAOF commented Aug 19, 2022

AlanGriffiths commented Aug 19, 2022

AlanGriffiths commented Aug 19, 2022

This comment was marked as outdated.

This comment was marked as outdated.

Saviq commented Aug 26, 2022

AlanGriffiths commented Aug 26, 2022

Saviq commented Aug 26, 2022 • edited

This comment was marked as outdated.

Saviq commented Aug 26, 2022 • edited by AlanGriffiths

rc8

Debs

Installed from from ppa:mir-team/rc

AlanGriffiths commented Aug 30, 2022

bors bot commented Aug 30, 2022

AlanGriffiths commented Aug 17, 2022 •

edited by Saviq

Saviq commented Aug 26, 2022 •

edited

Saviq commented Aug 26, 2022 •

edited by AlanGriffiths