Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle keyboard input sent to a non-focused surface #1626

Closed
wmww opened this issue Jul 23, 2020 · 0 comments · Fixed by #2223
Closed

Better handle keyboard input sent to a non-focused surface #1626

wmww opened this issue Jul 23, 2020 · 0 comments · Fixed by #2223

Comments

@wmww
Copy link
Contributor

wmww commented Jul 23, 2020

There's a mismatch between Mir's keyboard input model and Wayland's. In Mir, keyboard events get sent to surfaces, and in Wayland they get sent to seats. This means that it's theoretically possible for Mir input events to go to surfaces that have not been given keyboard focus, while this is not possible in Wayland. To bridge this gap, we have logic in WlKeyboard::key that just-in-time switches focus to the surface that's receiving the events.

This logic was always broken as explained in #1625. That PR seems to improve behavior, but doesn't appear to be completely correct. We should take another look at this whole problem, and make sure everything is doing what it should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant