Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differentiate between active surfaces and surfaces with keyboard input #2223

Merged
merged 5 commits into from
Nov 16, 2021

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Nov 16, 2021

Fixes #1626, fixes #2189. Adds a new mir_window_focus_state_active focus state, which is used for surfaces that are in the active stack but do not have keyboard focus. We did not previously have a way to represent this state properly, which caused us a number of problems.

Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible. But the logic is (pre-existing) gnarly - I need to experiment a bit to feel confident we've not introduced unexpected problems.

@AlanGriffiths
Copy link
Contributor

Yes, Seems to be an improvement.

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 16, 2021

Build succeeded:

@bors bors bot merged commit 86ebb35 into master Nov 16, 2021
@bors bors bot deleted the better-keyboard-focus branch November 16, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants