Keyboard focus/keyboard event inconsistancy #2331
Comments
wmww
changed the title
|
This is happening when opening weston-terminal. Repro:
|
|
Note that #2330 may have introduced this in practice or made it more common since it rearranged timing and order of the relevant calls, but the underlying race condition was always present. |
|
Fixed by #2339 |
I disagree. Reporting a problem quietly (as a log message) instead of loudly (fatal error) only reduces the severity of the manifestation. |
Merged
bors bot
added a commit
that referenced
this issue
May 24, 2022
2423: Release 2.8.0 r=AlanGriffiths,graysonguarino,RAOF,wmww,Saviq a=Saviq --- > - ABI summary: > - miral ABI unchanged at 4 > - mircommon ABI bumped to 9 > - mircookie ABI unchanged at 2 > - mircore ABI unchanged at 1 > - miroil ABI unchanged at 1 > - mirplatform ABI unchanged at 23 > - mirserver ABI bumped to 58 > - mirwayland ABI unchanged at 3 > - mirplatformgraphics ABI bumped to 20 > - mirinputplatform ABI unchanged at 8 > - Enhancements: > - Move generated protocol code to build directory (#2300) > - Allow --app-env-amend to be supplied multiple times (#2333) > - Make window title a configuration option (#2349) > - Add fatal_error if unable to bind Wayland socket (#2350) > - Add `mold` to the list of supported linkers (#2353) > - Platform refactoring towards hybrid GPU support (#2358, #2378, #2407) > - Implement wlr_screencopy_unstable_v1 for screenshots (#2383) > - Refactor out mf::MirDisplay (#2406) > - Bugs fixed: > - Synchronize buffer swaps to video frame in egl spinner (Fixes #2154) > - Do not give menus keyboard focus (Fixes #2324) > - Refactor Wayland keyboard input (Fixes #2331) > - Further simplify and correct keyboard focus setting (Fixes #2338) > - wl_pointer: do not send events when not compatible (Fixes #2341) > - Kill clients with error instead of sending unsupported (Fixes #2343) > - Initialize sig_handler_desc.sa_mask (#2386) > - Fix ThreadedDispatcherSignalTest.keeps_dispatching... (Fixes #2377) Co-authored-by: Michał Sawicz <michal@sawicz.net> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#2245 we get
If Mir sends the Wayland frontend keyboard events for a surface that does not have keyboard focus. The problem is there is no synchronization between switching keyboard focus and sending input events, so events sent to the wrong surface could intermittently slip through (this has not been observed in the wild AFAIK). We should either restore the old behavior, or somehow ensure events arrive correctly.
The text was updated successfully, but these errors were encountered: