Platform: New platform probe design #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are locations where we have a `dev_t` but will need a `udev::Device`. Make this possible
This lets other parts of Mir simply add a `target_link_libaries(... mirudev)` to get proper header handling.
This accomplishes multiple goals: * Platforms can now “bind” to a device, and the platform which claims to support that device best wins. * Platforms can list *each* device that they can drive, so later we can construct a `DisplayPlatform` or `RenderingPlatform` on the specific device. * Platforms can share data between the `probe` and construction phase
Log what type of driver we've selected (display or rendering), and fix the “Found <driver type> driver: $FOO” message
Even if the platform is not claiming to support a specific device, we still shouldn't return platforms which return `PlatformPriority::unsupported`.
The rendernode devices are /dev/dri/render*D*$NUMBER. Fixes probing the gbm-kms rendering platform.
We no longer have a nested platform in that sense!
There's no reason this requires the Mesa platform - the dummy platform is sufficient here.
…ormPriority::unsupported
…d a dummy platform
…ng its probing diagnostics
Saviq
reviewed
Apr 7, 2022
Turns out that `<span>` is one of the C++20 features not supported by 20.04's libstdc++. ☹
|
bors try This failed because of the WLCS update. |
tryBuild failed: |
…not be used depending on the set of built platforms
AlanGriffiths
requested changes
Apr 13, 2022
`MIR_SERVER_GRAPHICS_PLATFORM_STANZA_VERSION` is the variable we use for the graphics platform-DSO <-> libmirplatform ABI.
TODO: Do we *need* both halves?
|
I think this is right, but I'd prefer a second review before accepting it. |
Merged
bors bot
added a commit
that referenced
this pull request
May 24, 2022
2423: Release 2.8.0 r=AlanGriffiths,graysonguarino,RAOF,wmww,Saviq a=Saviq --- > - ABI summary: > - miral ABI unchanged at 4 > - mircommon ABI bumped to 9 > - mircookie ABI unchanged at 2 > - mircore ABI unchanged at 1 > - miroil ABI unchanged at 1 > - mirplatform ABI unchanged at 23 > - mirserver ABI bumped to 58 > - mirwayland ABI unchanged at 3 > - mirplatformgraphics ABI bumped to 20 > - mirinputplatform ABI unchanged at 8 > - Enhancements: > - Move generated protocol code to build directory (#2300) > - Allow --app-env-amend to be supplied multiple times (#2333) > - Make window title a configuration option (#2349) > - Add fatal_error if unable to bind Wayland socket (#2350) > - Add `mold` to the list of supported linkers (#2353) > - Platform refactoring towards hybrid GPU support (#2358, #2378, #2407) > - Implement wlr_screencopy_unstable_v1 for screenshots (#2383) > - Refactor out mf::MirDisplay (#2406) > - Bugs fixed: > - Synchronize buffer swaps to video frame in egl spinner (Fixes #2154) > - Do not give menus keyboard focus (Fixes #2324) > - Refactor Wayland keyboard input (Fixes #2331) > - Further simplify and correct keyboard focus setting (Fixes #2338) > - wl_pointer: do not send events when not compatible (Fixes #2341) > - Kill clients with error instead of sending unsupported (Fixes #2343) > - Initialize sig_handler_desc.sa_mask (#2386) > - Fix ThreadedDispatcherSignalTest.keeps_dispatching... (Fixes #2377) Co-authored-by: Michał Sawicz <michal@sawicz.net> Co-authored-by: bors[bot] <26634292+bors[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accomplishes multiple goals:
DisplayPlatformorRenderingPlatformon the specific device.probeand construction phase