Allow Window movement to be initiated by Wayland clients (Fixes #61) #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanGriffiths
force-pushed
the
csd-move
branch
from
3339158
to
3348e20
Compare
|
I know we also need to implement CSD move support in the tiling WM, but that's something for next week. |
wmww
approved these changes
Feb 16, 2018
|
Works well. One bug I've spotted though, not sure if it is compositor or client:
I'm upgrading to bionic to try GTK to see if it has the same issue. |
|
@gerboland yes, this is a problem. The trouble is we have recently landed some code that synthesises cursor move events to a surface that moves under the cursor. That code doesn't consider the possibility that the cursor and surface are moving together. And the synthetic events are not routed through the WM policy which "eats" other pointer events during the move. I move we land this (as being an improvement) and raise an issue about the synthetic events. |
gerboland
approved these changes
Feb 19, 2018
bors bot
added a commit
that referenced
this pull request
Feb 19, 2018
170: De-dup Cookie handle class r=gerboland a=AlanGriffiths 171: Allow Window movement to be initiated by Wayland clients (Fixes #61) r=gerboland a=AlanGriffiths 1. Connects up Wayland move() requests with the CSD move support. 2. Implements move in the "floating" window manager 3. Consolidates the move logic NB GTK apps on *Artful* don't work with this but Qt apps and weston-terminal do. (On Bionic, Fedora 27 and rawhide GTK apps seem fine.) 177: Bump the libmirserver sonumber r=gerboland a=AlanGriffiths We've broken ABI by changing SurfaceObserver. Bump the library version to match.
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB GTK apps on Artful don't work with this but Qt apps and weston-terminal do.
(On Bionic, Fedora 27 and rawhide GTK apps seem fine.)