Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miral-shell: if mouse down inside window moves over titlebar, titlebar takes it as a grab and moves window #61

Closed
gerboland opened this issue Nov 30, 2017 · 1 comment
Closed

miral-shell: if mouse down inside window moves over titlebar, titlebar takes it as a grab and moves window #61

gerboland opened this issue Nov 30, 2017 · 1 comment
Assignees
@AlanGriffiths

Comments

@gerboland
Copy link
Contributor

Steps to repro:

  1. Run miral-shell and the fingerpaint demo
  2. Press the mouse button down inside the fingerpaint app and wiggle it around to get painting
  3. Now with mouse button continually down, move the cursor up over the window titlebar

Expected result
Nothing happens, one can move the cursor back inside the window to continue drawing.

Actual result
The titlebar steals the mouse down, and will reposition the window as the mouse moves.
@AlanGriffiths AlanGriffiths self-assigned this Feb 16, 2018
AlanGriffiths added a commit that referenced this issue Feb 16, 2018
@AlanGriffiths
Reuse CSD move logic to replace existing titlebar move code (Fixes #61)
082ec81
AlanGriffiths added a commit that referenced this issue Feb 16, 2018
@AlanGriffiths
Reuse CSD move logic to replace existing titlebar move code (Fixes #61)
3339158
AlanGriffiths added a commit that referenced this issue Feb 16, 2018
@AlanGriffiths
Reuse CSD move logic to replace existing titlebar move code (Fixes #61)
3348e20
bors bot added a commit that referenced this issue Feb 19, 2018
@bors
Merge #170 #171 #177
651bec0 
170: De-dup Cookie handle class r=gerboland a=AlanGriffiths



171: Allow Window movement to be initiated by Wayland clients (Fixes #61) r=gerboland a=AlanGriffiths

1. Connects up Wayland move() requests with the CSD move support.
2. Implements move in the "floating" window manager
3. Consolidates the move logic

NB GTK apps on *Artful* don't work with this but Qt apps and weston-terminal do.
(On Bionic, Fedora 27 and rawhide GTK apps seem fine.)

177: Bump the libmirserver sonumber r=gerboland a=AlanGriffiths

We've broken ABI by changing SurfaceObserver. Bump the library version to match.
@AlanGriffiths
Copy link
Contributor

Sorted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlanGriffiths AlanGriffiths

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gerboland @AlanGriffiths