Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect GTest/GMock via pkg-config #635

Merged
merged 6 commits into from
Oct 31, 2018
Merged

Detect GTest/GMock via pkg-config #635

merged 6 commits into from
Oct 31, 2018

Conversation

AlanGriffiths
Copy link
Contributor

Detect GTest/GMock via pkg-config when possible. Otherwise fall back to the old huristic.

@AlanGriffiths AlanGriffiths mentioned this pull request Oct 31, 2018
Closed
@AlanGriffiths
Copy link
Contributor Author

Please @z3ntu, could you confirm this still works for you?

@z3ntu
Copy link
Contributor

z3ntu commented Oct 31, 2018

Using GTest v1.8.1 (parsed from pkg-config)

Works!

Saviq
Saviq approved these changes Oct 31, 2018
View reviewed changes
Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

bors r+

bors bot added a commit that referenced this pull request Oct 31, 2018
@bors @z3ntu @AlanGriffiths
Merge #635
7c3691e 
635: Detect GTest/GMock via pkg-config r=Saviq a=AlanGriffiths

Detect GTest/GMock via pkg-config when possible. Otherwise fall back to the old huristic.

Co-authored-by: Luca Weiss <luca@z3ntu.xyz>
Co-authored-by: Alan Griffiths <alan.griffiths@canonical.com>
@bors
Copy link
Contributor

bors bot commented Oct 31, 2018

Build failed

@AlanGriffiths
Copy link
Contributor Author

bors r=Saviq

bors bot added a commit that referenced this pull request Oct 31, 2018
@bors @z3ntu @AlanGriffiths
Merge #635
da1a652 
635: Detect GTest/GMock via pkg-config r=Saviq a=AlanGriffiths

Detect GTest/GMock via pkg-config when possible. Otherwise fall back to the old huristic.

Co-authored-by: Luca Weiss <luca@z3ntu.xyz>
Co-authored-by: Alan Griffiths <alan.griffiths@canonical.com>
@bors
Copy link
Contributor

bors bot commented Oct 31, 2018

Build succeeded

@bors bors bot merged commit d7bb680 into master Oct 31, 2018
@bors bors bot deleted the gtest-pkgconfig branch October 31, 2018 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saviq Saviq Saviq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlanGriffiths @z3ntu @Saviq