Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect exclusive zones #29

Closed
wants to merge 2 commits into from
Closed

Respect exclusive zones #29

wants to merge 2 commits into from

Conversation

wmww
Copy link
Contributor

@wmww wmww commented Oct 13, 2021

This augments #28 by preventing the OSK from obscuring the fullscreen app.

Copy link
Contributor

@AlanGriffiths AlanGriffiths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems messy to replicate the miral zone logic.

I still wonder if it can be spoofed by calling tools.place_and_size_for_state() with a spoofed modifications to get the corresponding mazimized placement.

@@ -25,23 +25,51 @@

#include <linux/input.h>
#include <unistd.h>
#include <limits>
#include <iostream>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need <iostream>

Comment on lines +312 to +313
std::cerr << "fatal: container_for_rect() called without any containers" << std::endl;
abort();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::cerr << "fatal: container_for_rect() called without any containers" << std::endl;
abort();
mir::fatal_error_abort("container_for_rect() called without any containers");

@wmww
Copy link
Contributor Author

wmww commented Oct 20, 2021

Alternative merged

@wmww wmww closed this Oct 20, 2021
@AlanGriffiths AlanGriffiths deleted the respect-exclusive-zones branch October 20, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants