Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - Force fullsceen windows to respect exclusive zones #32

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - Force fullsceen windows to respect exclusive zones #32

wants to merge 2 commits into from

Conversation

AlanGriffiths
Copy link
Contributor

Alternative to #29

@wmww
Copy link
Contributor

wmww commented Oct 19, 2021 •
edited

Issue:

  • Add: 
      wayland_extensions.enable(WaylandExtensions::zwlr_layer_shell_v1);
  wayland_extensions.enable(WaylandExtensions::zwp_virtual_keyboard_v1);
  wayland_extensions.enable(WaylandExtensions::zwp_input_method_v2);
    to frame_main.cpp
  • Run gedit
  • Run Squeekboard
  • Click hamburger menu (may have to hover mouse in the upper right for it to appear)
  • OSK disappears
  • Expected: gedit is resized to take up the whole screen
  • Actual: gedit stays half screened as if the OSK was still there

#29 does the right thing in this case

@AlanGriffiths
Copy link
Contributor Author

@wmww try again with snap refresh --channel edge/pr32 ubuntu-frame

wmww
wmww approved these changes Oct 19, 2021
View reviewed changes
Copy link
Contributor

@wmww wmww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
bors r+

bors bot pushed a commit that referenced this pull request Oct 19, 2021
@AlanGriffiths
Force fullsceen windows to respect exclusive zones (#32)
816c130 
Alternative to #29
@bors
Copy link

bors bot commented Oct 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title Force fullsceen windows to respect exclusive zones [Merged by Bors] - Force fullsceen windows to respect exclusive zones Oct 19, 2021
@bors bors bot closed this Oct 19, 2021
@bors bors bot deleted the fullscreen-exclusive-zones branch October 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmww wmww wmww approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AlanGriffiths @wmww