refactor: renaming remove observers

BREAKING CHANGE: NetworkPlayer.RemoveObservers renamed to RemoveAllVisibleObjects
MirageNet · Sep 8, 2021 · 12ffce7 · 12ffce7
1 parent d65d1e4
commit 12ffce7
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/Assets/Mirage/Runtime/INetworkPlayer.cs b/Assets/Mirage/Runtime/INetworkPlayer.cs
@@ -40,7 +40,7 @@ public interface IVisibilityTracker
     {
         void AddToVisList(NetworkIdentity identity);
         void RemoveFromVisList(NetworkIdentity identity);
-        void RemoveObservers();
+        void RemoveAllVisibleObjects();
     }
 
     /// <summary>

diff --git a/Assets/Mirage/Runtime/NetworkPlayer.cs b/Assets/Mirage/Runtime/NetworkPlayer.cs
@@ -169,7 +169,11 @@ public void RemoveFromVisList(NetworkIdentity identity)
             visList.Remove(identity);
         }
 
-        public void RemoveObservers()
+        /// <summary>
+        /// Removes all objects that this player can see
+        /// <para>This is called when loading a new scene</para>
+        /// </summary>
+        public void RemoveAllVisibleObjects()
         {
             foreach (NetworkIdentity identity in visList)
             {

diff --git a/Assets/Mirage/Runtime/ServerObjectManager.cs b/Assets/Mirage/Runtime/ServerObjectManager.cs
@@ -695,7 +695,7 @@ public void SetClientNotReady(INetworkPlayer player)
             {
                 if (logger.LogEnabled()) logger.Log("PlayerNotReady " + player);
                 player.SceneIsReady = false;
-                player.RemoveObservers();
+                player.RemoveAllVisibleObjects();
 
                 player.Send(new NotReadyMessage());
             }