perf: removing allocations for validating network identity in debug mode

Simple if check to avoid allocations when #if debug is defined when spawning network identities
MirageNet · Aug 7, 2022 · 1909749 · 1909749
1 parent 00ea2f2
commit 1909749
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/Assets/Mirage/Runtime/NetworkIdentity.cs b/Assets/Mirage/Runtime/NetworkIdentity.cs
@@ -286,7 +286,11 @@ private NetworkBehaviour[] FindBehaviourForThisIdentity()
             // we only need to do this in debug mode because results should be right
             foreach (var item in components)
             {
-                logger.Assert(item.Identity == this, $"Child NetworkBehaviour had a different Identity, this:{name}, Child Identity:{item.Identity.name}");
+                // assert
+                if (item.Identity != this)
+                {
+                    logger.LogError($"Child NetworkBehaviour had a different Identity, this:{name}, Child Identity:{item.Identity.name}");
+                }
             }
 #endif
             return components;