perf: eliminate small allocation on remote calls (#907)

* perf: eliminate small allocation on remote calls * Update NetworkBehaviour.cs
MirageNet · Jun 17, 2019 · 1c18743 · 1c18743
1 parent 8f6d4cb
commit 1c18743
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/Assets/Mirror/Runtime/NetworkBehaviour.cs b/Assets/Mirror/Runtime/NetworkBehaviour.cs
@@ -55,14 +55,18 @@ public int ComponentIndex
         {
             get
             {
-                int index = Array.FindIndex(netIdentity.NetworkBehaviours, component => component == this);
-                if (index < 0)
+                // note: FindIndex causes allocations, we search manually instead
+                for (int i = 0; i < netIdentity.NetworkBehaviours.Length; i++)
                 {
-                    // this should never happen
-                    Debug.LogError("Could not find component in GameObject. You should not add/remove components in networked objects dynamically", this);
+                    NetworkBehaviour component = netIdentity.NetworkBehaviours[i];
+                    if (component == this)
+                        return i;
                 }
 
-                return index;
+                // this should never happen
+                Debug.LogError("Could not find component in GameObject. You should not add/remove components in networked objects dynamically", this);
+
+                return -1;
             }
         }