feat: SyncDictionary raise event when initially synchronized

MirageNet · Oct 23, 2020 · 23349af · 23349af
1 parent 03f2075
commit 23349af
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/Assets/Mirror/Runtime/SyncDictionary.cs b/Assets/Mirror/Runtime/SyncDictionary.cs
@@ -167,18 +167,21 @@ public void OnDeserializeAll(NetworkReader reader)
 
             objects.Clear();
             changes.Clear();
+            OnClear?.Invoke();
 
             for (int i = 0; i < count; i++)
             {
                 TKey key = reader.Read<TKey>();
                 TValue obj = reader.Read<TValue>();
                 objects.Add(key, obj);
+                OnInsert?.Invoke(key, obj);
             }
 
             // We will need to skip all these changes
             // the next time the list is synchronized
             // because they have already been applied
             changesAhead = (int)reader.ReadPackedUInt32();
+            OnChange?.Invoke();
         }
 
         public void OnDeserializeDelta(NetworkReader reader)

diff --git a/Assets/Tests/Editor/SyncDictionaryTest.cs b/Assets/Tests/Editor/SyncDictionaryTest.cs
@@ -58,6 +58,36 @@ public void TestInit()
             Assert.That(clientSyncDictionary, Is.EquivalentTo(comparer));
         }
 
+        [Test]
+        public void ClearEventOnSyncAll()
+        {
+            Action callback = Substitute.For<Action>();
+            clientSyncDictionary.OnClear += callback;
+            SerializeAllTo(serverSyncDictionary, clientSyncDictionary);
+            callback.Received().Invoke();
+        }
+
+        [Test]
+        public void InsertEventOnSyncAll()
+        {
+            Action<int, string> callback = Substitute.For<Action<int, string>>();
+            clientSyncDictionary.OnInsert += callback;
+            SerializeAllTo(serverSyncDictionary, clientSyncDictionary);
+
+            callback.Received().Invoke(0, "Hello");
+            callback.Received().Invoke(1, "World");
+            callback.Received().Invoke(2, "!");
+        }
+
+        [Test]
+        public void ChangeEventOnSyncAll()
+        {
+            Action callback = Substitute.For<Action>();
+            clientSyncDictionary.OnChange += callback;
+            SerializeAllTo(serverSyncDictionary, clientSyncDictionary);
+            callback.Received().Invoke();
+        }
+
         [Test]
         public void TestAdd()
         {