fix: throw weaver error when trying to use GameObject param (#395)

* fix: throw weaver error when trying to use GameObject param

* add tests

* fix test

Assets/Mirror/Editor/Weaver/Readers.cs

@@ -57,6 +57,11 @@ public static MethodReference GetReadFunc(TypeReference variableReference)
                 Weaver.Error($"Cannot generate reader for {variableReference.Name}. Use a supported type or provide a custom reader", variableReference);
                 return null;
             }
+            if (variableReference.Is<UnityEngine.GameObject>())
+            {
+                Weaver.Error($"Cannot generate reader for {variableReference.Name}. Use a supported type or provide a custom reader", variableReference);
+                return null;
+            }
             if (variableReference.IsByReference)
             {
                 // error??

Assets/Mirror/Editor/Weaver/Writers.cs

@@ -106,6 +106,10 @@ static MethodDefinition GenerateWriter(TypeReference variableReference)
             {
                 throw new GenerateWriterException($"Cannot generate writer for {variableReference.Name}. Use a supported type or provide a custom writer", variableReference);
             }
+            if (variableReference.Is<UnityEngine.GameObject>())
+            {
+                throw new GenerateWriterException($"Cannot generate writer for {variableReference.Name}. Use a supported type or provide a custom writer", variableReference);
+            }
             if (variableDefinition.HasGenericParameters)
             {
                 throw new GenerateWriterException($"Cannot generate writer for generic type {variableReference.Name}. Use a supported type or provide a custom writer", variableReference);

Assets/Tests/Editor/Weaver/WeaverNetworkBehaviourTests.cs

@@ -186,6 +186,19 @@ public void NetworkBehaviourCmdParamComponent()
                 "System.Void WeaverNetworkBehaviourTests.NetworkBehaviourCmdParamComponent.NetworkBehaviourCmdParamComponent::CmdCantHaveParamComponent(WeaverNetworkBehaviourTests.NetworkBehaviourCmdParamComponent.NetworkBehaviourCmdParamComponent/ComponentClass)");
         }
 
+        [Test]
+        public void NetworkBehaviourCmdParamGameObject()
+        {
+            HasError("Cannot generate writer for GameObject. Use a supported type or provide a custom writer",
+                "UnityEngine.GameObject");
+            HasError("CmdCantHaveGameObjectComponent has invalid parameter monkeyComp",
+                "System.Void WeaverNetworkBehaviourTests.NetworkBehaviourCmdParamGameObject.NetworkBehaviourCmdParamGameObject::CmdCantHaveGameObjectComponent(UnityEngine.GameObject)");
+            HasError("Cannot generate reader for GameObject. Use a supported type or provide a custom reader",
+                "UnityEngine.GameObject");
+            HasError("CmdCantHaveGameObjectComponent has invalid parameter monkeyComp.  Unsupported type UnityEngine.GameObject,  use a supported Mirror type instead",
+                "System.Void WeaverNetworkBehaviourTests.NetworkBehaviourCmdParamGameObject.NetworkBehaviourCmdParamGameObject::CmdCantHaveGameObjectComponent(UnityEngine.GameObject)");
+        }
+
         [Test]
         public void NetworkBehaviourCmdDuplicateName()
         {

Assets/Tests/Editor/Weaver/WeaverNetworkBehaviourTests~/NetworkBehaviourCmdParamGameObject.cs

@@ -0,0 +1,11 @@
+using Mirror;
+using UnityEngine;
+
+namespace WeaverNetworkBehaviourTests.NetworkBehaviourCmdParamGameObject
+{
+    class NetworkBehaviourCmdParamGameObject : NetworkBehaviour
+    {
+        [ServerRpc]
+        public void CmdCantHaveGameObjectComponent(GameObject monkeyComp) { }
+    }
+}