-
-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
perf: Adding buffer for local connection (#1621)
* Using writer for local connection LocalConnectionBuffer * removing assert * fixing error and cleaning up code * removing old queue * tests for LocalConnectionBuffer * removing field * removing extra lines * Update LocalConnections.cs removing empty line * adding comment for packet count
- Loading branch information
1 parent
0ee5d52
commit 4d5cee8
Showing
3 changed files
with
198 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
142 changes: 142 additions & 0 deletions
142
Assets/Mirror/Tests/Editor/LocalConnectionBufferTest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,142 @@ | ||
using System; | ||
using NUnit.Framework; | ||
|
||
namespace Mirror.Tests | ||
{ | ||
public class LocalConnectionBufferTest | ||
{ | ||
readonly LocalConnectionBuffer buffer = new LocalConnectionBuffer(); | ||
|
||
[TearDown] | ||
public void TearDown() | ||
{ | ||
buffer.ResetBuffer(); | ||
} | ||
|
||
[Test] | ||
public void BufferHasPacketsAfterWriter() | ||
{ | ||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteString("Some Message"); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
|
||
Assert.IsTrue(buffer.HasPackets()); | ||
} | ||
[Test] | ||
public void BufferHasNoPacketsAfterWriteAndReading() | ||
{ | ||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteString("Some Message"); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
ArraySegment<byte> package = buffer.GetNextPacket(); | ||
|
||
|
||
Assert.IsFalse(buffer.HasPackets()); | ||
} | ||
[Test] | ||
public void BufferCanWriteAndReadPackages() | ||
{ | ||
const string expectedMessage = "Some Message"; | ||
const float expectedValue = 46.8f; | ||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteString(expectedMessage); | ||
writer.WriteSingle(expectedValue); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
ArraySegment<byte> package = buffer.GetNextPacket(); | ||
|
||
string message; | ||
float value; | ||
using (PooledNetworkReader reader = NetworkReaderPool.GetReader(package)) | ||
{ | ||
message = reader.ReadString(); | ||
value = reader.ReadSingle(); | ||
} | ||
|
||
Assert.That(message, Is.EqualTo(expectedMessage)); | ||
Assert.That(value, Is.EqualTo(expectedValue)); | ||
} | ||
[Test] | ||
public void BufferReturnsMutliplePacketsInTheOrderTheyWereWriten() | ||
{ | ||
const string expectedMessage1 = "first Message"; | ||
const string expectedMessage2 = "second Message"; | ||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteString(expectedMessage1); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
|
||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteString(expectedMessage2); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
|
||
string message1; | ||
string message2; | ||
ArraySegment<byte> package1 = buffer.GetNextPacket(); | ||
|
||
using (PooledNetworkReader reader = NetworkReaderPool.GetReader(package1)) | ||
{ | ||
message1 = reader.ReadString(); | ||
} | ||
|
||
Assert.IsTrue(buffer.HasPackets()); | ||
ArraySegment<byte> package2 = buffer.GetNextPacket(); | ||
|
||
using (PooledNetworkReader reader = NetworkReaderPool.GetReader(package2)) | ||
{ | ||
message2 = reader.ReadString(); | ||
} | ||
|
||
Assert.That(message1, Is.EqualTo(expectedMessage1)); | ||
Assert.That(message2, Is.EqualTo(expectedMessage2)); | ||
} | ||
[Test] | ||
public void BufferCanWriteReadMorePackageAfterCallingReset() | ||
{ | ||
const string expectedMessage = "Some Message"; | ||
const float expectedValue = 46.8f; | ||
|
||
for (int i = 0; i < 5; i++) | ||
{ | ||
using (PooledNetworkWriter writer = NetworkWriterPool.GetWriter()) | ||
{ | ||
writer.WriteInt32(i); | ||
writer.WriteString(expectedMessage); | ||
writer.WriteSingle(expectedValue); | ||
|
||
buffer.Write(writer.ToArraySegment()); | ||
} | ||
ArraySegment<byte> package = buffer.GetNextPacket(); | ||
|
||
int index; | ||
string message; | ||
float value; | ||
using (PooledNetworkReader reader = NetworkReaderPool.GetReader(package)) | ||
{ | ||
index = reader.ReadInt32(); | ||
message = reader.ReadString(); | ||
value = reader.ReadSingle(); | ||
} | ||
|
||
Assert.That(index, Is.EqualTo(i)); | ||
Assert.That(message, Is.EqualTo(expectedMessage)); | ||
Assert.That(value, Is.EqualTo(expectedValue)); | ||
|
||
buffer.ResetBuffer(); | ||
} | ||
} | ||
} | ||
} |
11 changes: 11 additions & 0 deletions
11
Assets/Mirror/Tests/Editor/LocalConnectionBufferTest.cs.meta
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.