fix: calling Connect and Authenticate handler twice (#102)

* Do not register Connect handler twice * fix tests * Don't let the manager auto start on github
MirageNet · Mar 22, 2020 · 515f5a1 · 515f5a1
1 parent 7e53d7e
commit 515f5a1
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/Assets/Mirror/Runtime/NetworkClient.cs b/Assets/Mirror/Runtime/NetworkClient.cs
@@ -179,7 +179,6 @@ internal void ConnectHost(NetworkServer server)
             if (LogFilter.Debug) Debug.Log("Client Connect Host to Server");
 
             RegisterSystemHandlers(true);
-            InitializeAuthEvents();
 
             connectState = ConnectState.Connected;
 

diff --git a/Assets/Mirror/Tests/Play/HostTests.cs b/Assets/Mirror/Tests/Play/HostTests.cs
@@ -1,5 +1,7 @@
-using NUnit.Framework;
+using System.Collections;
+using NUnit.Framework;
 using UnityEngine;
+using UnityEngine.TestTools;
 
 namespace Mirror.Tests
 {
@@ -19,18 +21,21 @@ public class HostTests<T> where T:NetworkBehaviour
         protected NetworkIdentity identity;
         protected T component;
 
-        [SetUp]
-        public void SetupHost()
+        [UnitySetUp]
+        public IEnumerator SetupHost()
         {
             networkManagerGo = new GameObject();
             manager = networkManagerGo.AddComponent<NetworkManager>();
             manager.client = networkManagerGo.GetComponent<NetworkClient>();
             manager.server = networkManagerGo.GetComponent<NetworkServer>();
             server = manager.server;
             client = manager.client;
-
+            manager.startOnHeadless = false;
             manager.autoCreatePlayer = false;
 
+            // wait for manager to Start()
+            yield return null;
+
             manager.StartHost();
 
             playerGO = new GameObject();