fix: fixing double types showing up in log settings if no namespace g…

…iven
MirageNet · Apr 14, 2022 · 5ea84d5 · 5ea84d5
1 parent 6e21877
commit 5ea84d5
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/Assets/Mirage/Runtime/Logging/LogSettingsSO.cs b/Assets/Mirage/Runtime/Logging/LogSettingsSO.cs
@@ -31,19 +31,20 @@ public string FullName
             static string CreateFullName(string name, string space)
             {
                 // special case when namespace is null we just return null
-                // see GetNameAndNameSapceFromFullname
-                if (space == null)
+                // see GetNameAndNameSpaceFromFullname
+                if (string.IsNullOrEmpty(space))
                     return name;
                 else
                     return $"{space}.{name}";
             }
 
             public LogType logLevel;
 
-            public LoggerSettings(string name, string Namespace, LogType level)
+            public LoggerSettings(string name, string @namespace, LogType level)
             {
-                Name = name;
-                this.Namespace = Namespace;
+                // if string is null, use empty string instead
+                Name = name ?? string.Empty;
+                Namespace = @namespace ?? string.Empty;
                 logLevel = level;
                 fullNameCache = CreateFullName(Name, Namespace);
             }