perf: messages should be value types (#987)

MirageNet · Jul 29, 2019 · 633fb19 · 633fb19
1 parent 7c7c910
commit 633fb19
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 7 deletions.
diff --git a/Assets/Mirror/Runtime/Messages.cs b/Assets/Mirror/Runtime/Messages.cs
@@ -356,27 +356,40 @@ public override void Serialize(NetworkWriter writer)
 
     // A client sends this message to the server
     // to calculate RTT and synchronize time
-    class NetworkPingMessage : DoubleMessage
+    struct NetworkPingMessage : IMessageBase
     {
-        public NetworkPingMessage() {}
+        public double clientTime;
+
+        public NetworkPingMessage(double value)
+        {
+            clientTime = value;
+        }
 
-        public NetworkPingMessage(double value) : base(value) {}
+        public void Deserialize(NetworkReader reader)
+        {
+            clientTime = reader.ReadDouble();
+        }
+
+        public void Serialize(NetworkWriter writer)
+        {
+            writer.Write(clientTime);
+        }        
     }
 
     // The server responds with this message
     // The client can use this to calculate RTT and sync time
-    class NetworkPongMessage : MessageBase
+    struct NetworkPongMessage : IMessageBase
     {
         public double clientTime;
         public double serverTime;
 
-        public override void Deserialize(NetworkReader reader)
+        public void Deserialize(NetworkReader reader)
         {
             clientTime = reader.ReadDouble();
             serverTime = reader.ReadDouble();
         }
 
-        public override void Serialize(NetworkWriter writer)
+        public void Serialize(NetworkWriter writer)
         {
             writer.WriteDouble(clientTime);
             writer.WriteDouble(serverTime);

diff --git a/Assets/Mirror/Runtime/NetworkTime.cs b/Assets/Mirror/Runtime/NetworkTime.cs
@@ -64,7 +64,7 @@ internal static void OnServerPing(NetworkConnection conn, NetworkPingMessage msg
 
             NetworkPongMessage pongMsg = new NetworkPongMessage
             {
-                clientTime = msg.value,
+                clientTime = msg.clientTime,
                 serverTime = LocalTime()
             };