fix: fixing register button not setting holder as dirty

MirageNet · Apr 5, 2023 · 762e295 · 762e295
1 parent 0636a33
commit 762e295
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/Assets/Mirage/Editor/ClientObjectManagerInspector.cs b/Assets/Mirage/Editor/ClientObjectManagerInspector.cs
@@ -85,8 +85,9 @@ public void MovePrefabsToSO()
             var com = (ClientObjectManager)target;
 
             // add to new
-            Undo.RecordObject(com.NetworkPrefabs, "Adding prefabs from com.spawnPrefabs");
+            Undo.RecordObject(com.NetworkPrefabs, "Adding prefabs to SO {com.NetworkPrefabs.name}");
             NetworkPrefabUtils.AddToPrefabList(com.NetworkPrefabs.Prefabs, com.spawnPrefabs);
+            EditorUtility.SetDirty(com.NetworkPrefabs);
 
             // clear old
             var listProp = serializedObject.FindProperty(nameof(ClientObjectManager.spawnPrefabs));
@@ -103,12 +104,13 @@ public void RegisterAllPrefabs()
             // first use networkprefabs for list, if null then use the list field
             if (com.NetworkPrefabs != null)
             {
-                Undo.RecordObject(com.NetworkPrefabs, "Register prefabs for spawn");
+                Undo.RecordObject(com.NetworkPrefabs, $"Register All Prefabs to SO {com.NetworkPrefabs.name}");
                 NetworkPrefabUtils.AddToPrefabList(com.NetworkPrefabs.Prefabs, foundPrefabs);
+                EditorUtility.SetDirty(com.NetworkPrefabs);
             }
             else
             {
-                Undo.RecordObject(target, "Register prefabs for spawn");
+                Undo.RecordObject(com.NetworkPrefabs, $"Register All Prefabs to COM {com.name}");
                 PrefabUtility.RecordPrefabInstancePropertyModifications(target);
                 NetworkPrefabUtils.AddToPrefabList(com.spawnPrefabs, foundPrefabs);
             }

diff --git a/Assets/Mirage/Editor/NetworkPrefabsInspector.cs b/Assets/Mirage/Editor/NetworkPrefabsInspector.cs
@@ -22,8 +22,9 @@ public void RegisterPrefabs()
 
             var target = (NetworkPrefabs)this.target;
 
-            Undo.RecordObject(target, "Register prefabs for spawn");
+            Undo.RecordObject(target, $"Register All Prefabs to SO {target.name}");
             NetworkPrefabUtils.AddToPrefabList(target.Prefabs, foundPrefabs);
+            EditorUtility.SetDirty(target);
         }
     }
 }
diff --git a/Assets/Mirage/Editor/NetworkedPrefabAttributeDrawer.cs b/Assets/Mirage/Editor/NetworkedPrefabAttributeDrawer.cs
@@ -271,6 +271,9 @@ private static void Register(IEnumerable<NetworkPrefabs> allHolders, NetworkIden
             {
                 Undo.RecordObject(holder, $"Adding {prefab.name} to {holder.name}");
                 holder.Prefabs.Add(prefab);
+
+                // seems like we need to also mark dirty for non-scene objects
+                EditorUtility.SetDirty(holder);
             }
             GUIUtility.ExitGUI();
         }