perf: use value types for empty messages (#988)

MirageNet · Jul 29, 2019 · 81d915e · 81d915e
1 parent 12437ba
commit 81d915e
Showing 1 changed file with 42 additions and 7 deletions.
diff --git a/Assets/Mirror/Runtime/Messages.cs b/Assets/Mirror/Runtime/Messages.cs
@@ -142,17 +142,42 @@ public class EmptyMessage : MessageBase
     #region Public System Messages
     public class ErrorMessage : ByteMessage {}
 
-    public class ReadyMessage : EmptyMessage {}
+    public class ReadyMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
+
+        public void Serialize(NetworkWriter writer) { }
+    }
 
-    public class NotReadyMessage : EmptyMessage {}
+    public class NotReadyMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
+
+        public void Serialize(NetworkWriter writer) { }
+    }
 
     public class AddPlayerMessage : BytesMessage {}
 
-    public class RemovePlayerMessage : EmptyMessage {}
+    public class RemovePlayerMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
 
-    public class DisconnectMessage : EmptyMessage {}
+        public void Serialize(NetworkWriter writer) { }
+    }
 
-    public class ConnectMessage : EmptyMessage {}
+    public class DisconnectMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
+
+        public void Serialize(NetworkWriter writer) { }
+    }
+
+    public class ConnectMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
+
+        public void Serialize(NetworkWriter writer) { }
+    }
 
     public class SceneMessage : MessageBase
     {
@@ -282,9 +307,19 @@ public override void Serialize(NetworkWriter writer)
         }
     }
 
-    class ObjectSpawnStartedMessage : EmptyMessage {}
+    class ObjectSpawnStartedMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
+
+        public void Serialize(NetworkWriter writer) { }
+    }
+
+    class ObjectSpawnFinishedMessage : IMessageBase
+    {
+        public void Deserialize(NetworkReader reader) { }
 
-    class ObjectSpawnFinishedMessage : EmptyMessage {}
+        public void Serialize(NetworkWriter writer) { }
+    }
 
     class ObjectDestroyMessage : MessageBase
     {