fix: fixing server setting HasAuthority to true

HasAuthority should not be used on server, so should always be false. Because of the changes to syncvar sender checking HasAuthority we need to ensure that it is false on server
MirageNet · May 16, 2023 · a6fa26d · a6fa26d
1 parent 21e6a5a
commit a6fa26d
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Assets/Mirage/Runtime/ServerObjectManager.cs b/Assets/Mirage/Runtime/ServerObjectManager.cs
@@ -155,7 +155,7 @@ public void ReplaceCharacter(INetworkPlayer player, NetworkIdentity identity, bo
             identity.SetClientOwner(player);
 
             // special case,  we are in host mode,  set hasAuthority to true so that all overrides see it
-            if (player == _server.LocalPlayer)
+            if (_server.LocalPlayer != null && player == _server.LocalPlayer)
             {
                 identity.HasAuthority = true;
                 _server.LocalClient.Player.Identity = identity;
@@ -217,7 +217,7 @@ public void AddCharacter(INetworkPlayer player, NetworkIdentity identity)
             identity.SetClientOwner(player);
 
             // special case, we are in host mode, set hasAuthority to true so that all overrides see it
-            if (player == _server.LocalPlayer)
+            if (_server.LocalPlayer != null && player == _server.LocalPlayer)
             {
                 identity.HasAuthority = true;
                 _server.LocalClient.Player.Identity = identity;
@@ -415,7 +415,9 @@ public void Spawn(NetworkIdentity identity)
 
             // special case to make sure hasAuthority is set
             // on start server in host mode
-            if (identity.Owner == _server.LocalPlayer)
+            // note: we need != null here, HasAuthority should never be null on server
+            //       this is so that logic in syncvar sender works correctly
+            if (_server.LocalPlayer != null && identity.Owner == _server.LocalPlayer)
                 identity.HasAuthority = true;
 
             if (!identity.IsSpawned)