fix: network objects not destroyed on server stop (#468)

* bug: network objects not destroyed on server stop

* hook Server.Stopped and loop through Spawned to Destroy all objects

* no need to call Client.Update() manually

* fix failing test. setup was not waiting for client to spawn player

Assets/Mirror/Runtime/ServerObjectManager.cs

@@ -1,5 +1,6 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using Mirror.RemoteCalls;
 using UnityEngine;
 
@@ -32,6 +33,7 @@ public void Start()
             {
                 server.Started.AddListener(SpawnOrActivate);
                 server.Authenticated.AddListener(OnAuthenticated);
+                server.Stopped.AddListener(OnServerStopped);
                 networkSceneManager.ServerChangeScene.AddListener(OnServerChangeScene);
                 networkSceneManager.ServerSceneChanged.AddListener(OnServerSceneChanged);
             }
@@ -81,6 +83,14 @@ void OnAuthenticated(INetworkConnection connection)
             RegisterMessageHandlers(connection);
         }
 
+        void OnServerStopped()
+        {
+            foreach (NetworkIdentity obj in server.Spawned.Values.Reverse())
+            {
+                DestroyObject(obj, true);
+            }
+        }
+
         void OnServerChangeScene(string scenePath, SceneOperation sceneOperation)
         {
             SetAllClientsNotReady();

Assets/Tests/Runtime/HostSetup.cs

@@ -57,7 +57,8 @@ public class HostSetup<T> where T : NetworkBehaviour
 
             serverObjectManager.AddPlayerForConnection(server.LocalConnection, playerGO);
 
-            client.Update();
+            // wait for client to spawn it
+            await AsyncUtil.WaitUntilWithTimeout(() => client.Connection.Identity != null);
         });
 
 

Assets/Tests/Runtime/ServerObjectManagerTest.cs

@@ -122,6 +122,22 @@ public void UnSpawn()
             // it should have been marked for reset now
             Assert.That(identity.NetId, Is.Zero);
         }
+
+        [UnityTest]
+        public IEnumerator DestroyAllSpawnedOnStopTest() => UniTask.ToCoroutine(async () =>
+        {
+            GameObject spawnTestObj = new GameObject("testObj", typeof(NetworkIdentity));
+            serverObjectManager.Spawn(spawnTestObj);
+
+            //1 is the player. should be 2 at this point
+            Assert.That(server.Spawned.Count, Is.GreaterThan(1));
+
+            server.Disconnect();
+
+            await AsyncUtil.WaitUntilWithTimeout(() => !server.Active);
+
+            Assert.That(server.Spawned.Count, Is.EqualTo(0));
+        });
     }
 
     public class ServerObjectManagerTest : ClientServerSetup<MockComponent>