fix: renameing identity.Reset so it doesn't override unity's reset fu…

…nction

Unity uses the Reset method when doing right click reset. If we override it then we can't reset the ids manually if something goes wrong

Assets/Mirage/Runtime/ClientObjectManager.cs

@@ -332,7 +332,7 @@ void UnSpawn(NetworkIdentity identity)
             }
             else
             {
-                identity.Reset();
+                identity.NetworkReset();
                 identity.gameObject.SetActive(false);
                 spawnableObjects[identity.sceneId] = identity;
             }

Assets/Mirage/Runtime/NetworkIdentity.cs

@@ -173,7 +173,7 @@ public sealed class NetworkIdentity : MonoBehaviour
         public NetworkWorld World { get; internal set; }
 
         [Header("Runtime References")]
-        
+
         /// <summary>
         /// The ServerObjectManager is present only for server/host instances.
         /// </summary>
@@ -1144,7 +1144,8 @@ public void RemoveClientAuthority()
         /// as people might want to be able to read the members inside OnDestroy(), and we have no way
         /// of invoking reset after OnDestroy is called.
         /// </summary>
-        internal void Reset()
+        // IMPORTANT: dont use `Reset` as function name because that is a unity callback
+        internal void NetworkReset()
         {
             ResetSyncObjects();
 

Assets/Mirage/Runtime/ServerObjectManager.cs

@@ -639,7 +639,7 @@ void DestroyObject(NetworkIdentity identity, bool destroyServerObject)
 
             identity.StopServer();
 
-            identity.Reset();
+            identity.NetworkReset();
             // when unspawning, dont destroy the server's object
             if (destroyServerObject)
             {

Assets/Tests/Editor/NetworkIdentityCallbackTests.cs

@@ -684,7 +684,7 @@ public void Reset()
             identity.observers.Add(player1);
 
             // mark for reset and reset
-            identity.Reset();
+            identity.NetworkReset();
             Assert.That(identity.NetId, Is.EqualTo(0));
             Assert.That(identity.Owner, Is.Null);
         }