perf: simplify NetworkWriter/Reader dispose (#431)

MirageNet · Oct 23, 2020 · bf62345 · bf62345
1 parent ea0340e
commit bf62345
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 14 deletions.
diff --git a/Assets/Mirror/Runtime/NetworkReaderPool.cs b/Assets/Mirror/Runtime/NetworkReaderPool.cs
@@ -6,19 +6,13 @@ namespace Mirror
     /// <summary>
     /// NetworkReader to be used with <see cref="NetworkReaderPool">NetworkReaderPool</see>
     /// </summary>
-    public class PooledNetworkReader : NetworkReader, IDisposable
+    public sealed class PooledNetworkReader : NetworkReader, IDisposable
     {
         internal PooledNetworkReader(byte[] bytes) : base(bytes) { }
 
         internal PooledNetworkReader(ArraySegment<byte> segment) : base(segment) { }
 
         public void Dispose()
-        {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        public virtual void Dispose(bool disposing)
         {
             NetworkReaderPool.Recycle(this);
         }

diff --git a/Assets/Mirror/Runtime/NetworkWriterPool.cs b/Assets/Mirror/Runtime/NetworkWriterPool.cs
@@ -6,15 +6,9 @@ namespace Mirror
     /// <summary>
     /// NetworkWriter to be used with <see cref="NetworkWriterPool">NetworkWriterPool</see>
     /// </summary>
-    public class PooledNetworkWriter : NetworkWriter, IDisposable
+    public sealed class PooledNetworkWriter : NetworkWriter, IDisposable
     {
         public void Dispose() {
-            Dispose(true);
-            GC.SuppressFinalize(this);
-        }
-
-        public virtual void Dispose(bool disposing)
-        {
             NetworkWriterPool.Recycle(this);
         }
     }